Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always set 'use_default_shell_env' in ctx.actions.run #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

always set 'use_default_shell_env' in ctx.actions.run #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ts/private/ts_project.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ This is an error because Bazel does not run actions unless their outputs are nee
env = {
"BAZEL_BINDIR": ctx.bin_dir.path,
},
use_default_shell_env = True,
)

transitive_sources = js_lib_helpers.gather_transitive_sources(output_sources, ctx.attr.srcs + [ctx.attr.tsconfig] + ctx.attr.deps)
Expand Down
1 change: 1 addition & 0 deletions ts/private/ts_proto_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def _protoc_action(ctx, proto_info, outputs, options = {
[ctx.executable.protoc_gen_connect_query] if ctx.attr.gen_connect_query else []
),
env = {"BAZEL_BINDIR": ctx.bin_dir.path},
use_default_shell_env = True,
)

def _declare_outs(ctx, info, ext):
Expand Down
1 change: 1 addition & 0 deletions ts/private/ts_validate_options.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def _validate_action(ctx, tsconfig_inputs):
env = {
"BAZEL_BINDIR": ctx.bin_dir.path,
},
use_default_shell_env = True,
)

return [marker]
Expand Down