Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Aspect Workflows #100

Merged
merged 1 commit into from
Sep 7, 2024
Merged

chore: add Aspect Workflows #100

merged 1 commit into from
Sep 7, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Sep 6, 2024

Onboard rules_terser to Aspect Workflows on GCP + CircleCI.

@gregmagolan gregmagolan force-pushed the add_workflows branch 5 times, most recently from 74aaefd to 57660dc Compare September 6, 2024 18:16
@gregmagolan gregmagolan marked this pull request as ready for review September 6, 2024 23:30
@gregmagolan gregmagolan requested review from jbedard and kormide and removed request for kormide September 6, 2024 23:34
@gregmagolan gregmagolan merged commit 48d1a45 into main Sep 7, 2024
16 checks passed
@gregmagolan gregmagolan deleted the add_workflows branch September 7, 2024 00:55
@kormide
Copy link
Member

kormide commented Sep 7, 2024

Is there a reason to not use rules_workflows for generating the circle config? Is it just because 5.11 isn't supported yet?

@gregmagolan
Copy link
Member Author

gregmagolan commented Sep 7, 2024

Is there a reason to not use rules_workflows for generating the circle config? Is it just because 5.11 isn't supported yet?

I'm planning to upgrade these to use rules_workflows soon in a follow-up. rules_workflows API needs finalization which was is why I hadn't rolled it out broadly yet. Once the API settles I'll roll it out here and to aspect-cli repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants