refactor: don't default chdir to package_name() in _cypress_test_macro [BREAKING] #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
gregmagolan
force-pushed
the
dont_default_chdir
branch
2 times, most recently
from
6749552 to
f7ae7e8
Compare
gregmagolan
force-pushed
the
dont_default_chdir
branch
6 times, most recently
from
5e7fa10 to
fcabc78
Compare
gregmagolan
force-pushed
the
dont_default_chdir
branch
from
fcabc78 to
72cc7c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Bazel Slack thread: https://bazelbuild.slack.com/archives/C04281DTLH0/p1714238140731229?thread_ts=1713995693.705169&cid=C04281DTLH0
Changes are visible to end-users: yes
BREAKING CHANGES
cypress_testandcypress_module_testno longer defaultchdirtopackage_name()under the hood. This is to align rules_cypress with the rest of the rules_js rulesets. Users must now setchdirexplicitly on these rules.Test plan