fix: Disable sandboxing for cypress_test rules #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeku
force-pushed
the
no-sandbox
branch
6 times, most recently
from
b6b6d13 to
11b4b2e
Compare
jbedard
reviewed
Apr 19, 2024
jbedard
reviewed
Apr 19, 2024
gregmagolan
reviewed
Apr 25, 2024
gregmagolan
reviewed
Apr 25, 2024
gregmagolan
reviewed
Apr 25, 2024
mrmeku
force-pushed
the
no-sandbox
branch
3 times, most recently
from
f85544d to
eda9d77
Compare
gregmagolan
reviewed
Apr 29, 2024
gregmagolan
reviewed
Apr 29, 2024
gregmagolan
reviewed
Apr 29, 2024
jbedard
reviewed
Apr 30, 2024
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 1, 2024
variable RUN_ELECTRON_AS_NODE which makes it hard to keep up with their electron server's sandboxing violations. We now disable the sandbox so that user's can don't run into these issues.
- Switch to `disable_sandbox` defaulting to true - Removed unused attribute from rule impl
gregmagolan
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress has moved away from supporting the env
variable RUN_ELECTRON_AS_NODE which makes it
hard to keep up with their electron server's
sandboxing violations. We now disable the sandbox
so that user's can don't run into these issues.
Type of change
Test plan
(using a cypress version 13.6.6 required this change on macOS)