Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cypress 13.5.0 #56

Closed
wants to merge 1 commit into from
Closed

chore: add cypress 13.5.0 #56

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Nov 9, 2023

Also, re-generate checksums for older versions since the linux checksums have changed

"13.3.1": {
"darwin-x64": "417c5f1d77e15c8aef0a55f155c16c3dbbc637f918c1e51f8fec6eb1c73a9ba9",
"darwin-arm64": "143d905779c0b0a8a9049b0eb68b4b156db3d838d4546ce5082a8f7bd5dc5232",
"linux-x64": "a165aa290d23d03f191852df2e8c3cb25ddccf1d4e226518a0a217f4ec405328",
"linux-arm64": "b51810d7fda748f67d5d875d5e265ee22bb394af2bb4a545b78c99f1aae91cb0",
"linux-x64": "bb0ddd980bd82792a477b1c39ce8a0a7b275481031c559c065c94f1131151b0c",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these change for old versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed upstream so I re-generated all of the hashes

@gregmagolan gregmagolan requested a review from jbedard November 9, 2023 02:16
@gregmagolan
Copy link
Member Author

//cypress/tests/module_test:module_test test target started failing in strange way with this upgrade:

==================== Test output for //cypress/tests/module_test:module_test:
Note: You have set the environment variable:

CYPRESS_RUN_BINARY=../../../../cypress_linux-x64/Cypress/Cypress

This overrides the default Cypress binary path used.

[34:1109/022151.364734:ERROR:object_proxy.cc(590)] Failed to call method: org.freedesktop.portal.Settings.Read: object_path= /org/freedesktop/portal/desktop: unknown error type: 

DevTools listening on ws://127.0.0.1:38663/devtools/browser/0d479b79-f6bb-47d0-8273-f4c646a88e1c
Couldn't find tsconfig.json. tsconfig-paths will be skipped

tput: No value for $TERM and no -T specified

Not sure what is going on. The test case is passing but cypress exits with non-zero code. @mrmeku Any ideas?

@jackvincentnz
Copy link
Contributor

I separated out the checksum upgrade here since I think we should fix that before looking at the version 13 upgrade issue: #58

@alexeagle
Copy link
Member

I mirrored the latest version.

@alexeagle alexeagle closed this Mar 1, 2024
frc971-automation pushed a commit to frc971/971-Robot-Code that referenced this pull request Mar 7, 2024
I was debugging some QR code detection and wondered if the old
versions of these 2 pieces had anything to do with the issues.
Upgrading didn't help, but I figured it's worth keeping.

This patch updates Chromium to latest and Cypress to near-latest. I
had to pull in an upstream patch for rules_cypress because upstream
Cypress changed their released tarballs. So the checksums needed to
change. I didn't update Cypress to latest because of a reported issue:
aspect-build/rules_cypress#56 (comment)

As far as I can tell, there are no functional changes.

Signed-off-by: Philipp Schrader <[email protected]>
Change-Id: I04592e367cf1de94fe4243c7542d06ce7b16a418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants