chore: add windows release #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
windows_release
branch
from
2716670
to
113d0d6
Compare
|
alexeagle
force-pushed
the
windows_release
branch
5 times, most recently
from
aebeecd
to
5e8d906
Compare
thesayyn
force-pushed
the
windows_release
branch
4 times, most recently
from
b7dc4ba
to
f362963
Compare
|
Holding this for now so that @jbedard can sync the commits from silo first |
|
Lets merge #749 first |
Merged |
use host toolchain on windows chore: try again chore: update rules_go to pick up bazel-contrib/rules_go#4050 use mingw-gcc on windows setupgcc llvm windows latest build try to build python smoke revert most cache smoke test revert test release make python conditional checkout repo chore: fmt chore: restore bazeliskrc chore: keep
alexeagle
force-pushed
the
windows_release
branch
from
ac909b8
to
c151588
Compare
|
@gregmagolan I rebased, please review 🙏🏻 |
|
Note, I didn't re-test the release workflow end-to-end after rebasing. When this lands on main we'll be able to trigger the workflow through the UI. Possible it will need a bit of debugging if the first attempt doesn't go through. |
thesayyn
reviewed
Oct 1, 2024
alexeagle
force-pushed
the
windows_release
branch
3 times, most recently
from
7535d68
to
3d269ec
Compare
alexeagle
force-pushed
the
windows_release
branch
14 times, most recently
from
a5d49c5
to
eb4bd88
Compare
alexeagle
force-pushed
the
windows_release
branch
from
eb4bd88
to
08fde07
Compare
thesayyn
force-pushed
the
windows_release
branch
4 times, most recently
from
62ed681
to
a3ed0a5
Compare
thesayyn
force-pushed
the
windows_release
branch
from
a3ed0a5
to
587f798
Compare
thesayyn
approved these changes
Oct 3, 2024
|
@alexeagle this is all ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.