chore(copybara): sync commits from Aspect-internal silo #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
8AEF12339515D0A47D3EA1E9D42A18D8
branch
from
df82d17
to
dab6b73
Compare
jbedard
approved these changes
Aug 11, 2023
alexeagle
force-pushed
the
8AEF12339515D0A47D3EA1E9D42A18D8
branch
from
d35ed21
to
dcbc1d7
Compare
3 tasks
alexeagle
force-pushed
the
8AEF12339515D0A47D3EA1E9D42A18D8
branch
from
8233e02
to
13e12e1
Compare
I'm not sure if we have to reference this somewhere to get it onto the site? Where are the .md files converted to HTML? Just copying the directives.md might be fine for now, but I think this could also use some re-arranging and organizing. It's quite confusing what should go into: * [guides/configure.md](https://github.com/aspect-build/silo/blob/main/docs/versioned/cli/commands/aspect_configure.md) * [commands/configure.md](https://github.com/aspect-build/silo/blob/main/docs/versioned/cli/commands/aspect_configure.md) * [help/topics/directives.md](cli/core/docs/help/topics/directives.md) Currently information is spread and a bit duplicated across all of those, and it's unclear which direction thing should be linking etc. --------- Co-authored-by: Jason Bedard <[email protected]> Co-authored-by: Alex Eagle <[email protected]> GitOrigin-RevId: a6f3b2503be36b1d512495ea1564153b416c17d9
alexeagle
force-pushed
the
8AEF12339515D0A47D3EA1E9D42A18D8
branch
from
1703e4f
to
e3febd0
Compare
Anything else you can think of to add now? --------- Co-authored-by: Alex Eagle <[email protected]> GitOrigin-RevId: 0ef391edfcdb89ed24e253b27cde85301f215c6e
GitOrigin-RevId: 762169dfe192a8c5ac31f269fe59908f335ea078
GitOrigin-RevId: 9d6f904f0c50ec48d81767b6b264db7b300327e0
…l deps (#2998) GitOrigin-RevId: ed09073be587906135e32de4089a9c75ae1d45de
Picks up a visibility change so we can drop a patch That way we don't need to patch it in the aspect-cli repo too. --- ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Covered by existing test cases --------- Co-authored-by: Jason Bedard <[email protected]> GitOrigin-RevId: dc6e3f9df4b286b3417a45c73b9dfa7a0500911a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/9303ff8be17621396f6c20bf7700f76bfe4fcf5e..dc6e3f9df4b286b3417a45c73b9dfa7a0500911a