Merge pull request #21 from jgaskins/optimize-unique

Optimize `unique_*` methods
askn · Apr 21, 2024 · 9223359 · 9223359
2 parents c8875e3 + 4b7ace6
commit 9223359
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/faker/base.cr b/src/faker/base.cr
@@ -6,7 +6,7 @@ module Faker
     alias Any = String | Int32 | Float64 | Time
 
     macro uniquify_builder(attribute_name, *modified_method_attributes)
-      @@__unique_vals_for_{{attribute_name}} = Array(Any).new
+      @@__unique_vals_for_{{attribute_name}} = Set(Any).new
 
       def self.unique_{{attribute_name}}({% if !modified_method_attributes.empty? %}{{*modified_method_attributes}},{% end %} max_retries = 10_0000)
         max_retries.times do |t|