Dev 0.0.15 #176
Merged
Dev 0.0.15 #176
+216
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logging - Enhanced dropdown button styling with dynamic background based on open state - Added console logging for dropdown button active state - Adjusted display name text alignment and added inline flex for better rendering
- Enabled default prevention for Command+K (Mac) and Ctrl+K (Windows/Linux) keyboard shortcut - Ensures proper dropdown navigation when using keyboard shortcuts
…ific sites - Introduced BlockConfig utility to manage shortcut disabling for specific websites - Added SHORTCUT_DISABLED_PAGES configuration in preferences - Implemented shortcut blocking mechanism with URL pattern matching - Enhanced AskPanel and background script to handle shortcut-specific behaviors - Added Notification component for user feedback on disabled shortcuts
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the Askman Chrome extension. The changes focus on enhancing keyboard shortcut management, improving user interface elements, and updating configuration settings.
Enhancements to Keyboard Shortcut Management:
BlockConfigclass to manage pages where keyboard shortcuts are disabled, and integrated it into theAskPanelandAppcomponents (src/utils/BlockConfig.ts,src/components/ask-panel.tsx,src/pages/content/ui/app.tsx). [1] [2] [3]StorageManagerto support saving and retrievingSHORTCUT_DISABLED_PAGESfrom user preferences (src/utils/StorageManager.ts). [1] [2] [3] [4]User Interface Improvements:
Notificationcomponent to display messages to users (src/components/base/Notification.tsx).BaseDropdowncomponent to conditionally apply styles and added logging for debugging (src/components/base/BaseDropdown.tsx). [1] [2]KeyBindingcomponent to accept children elements for more flexible usage (src/components/icons.tsx).Configuration Updates:
external-links.tomlto change the documentation link (src/assets/conf/external-links.toml).ASK_BUTTON_BLOCK_PAGEand introducedSHORTCUT_DISABLED_PAGESinpreferences.toml(src/assets/conf/preferences.toml).Miscellaneous Changes:
package.jsonversion from 0.0.13 to 0.0.15 (package.json).BlockConfigimport and initialization inask-panel.tsx(src/components/ask-panel.tsx). [1] [2]These changes collectively improve the extension's usability by better managing keyboard shortcuts, enhancing user notifications, and updating configuration settings.