Implement the ZeroMQ transport #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelSarle
force-pushed
the
samuel/impl-zmq-transport
branch
from
4ebc035 to
85af8a6
Compare
SamuelSarle
force-pushed
the
samuel/impl-zmq-transport
branch
2 times, most recently
from
50647e8 to
0f5c529
Compare
When a `Connected` input port receives a `CloseOutput` event for for the last output port ID switch back to the `Open` state.
The conditions for the `loop { tokio::select!( ... ) }` to exit are:
1. All the references to `req_send` channel are dropped. This channel is
used by the public transport interface to close the port. It clones
the `Sender` and `send().awaits` on it. Once all of those have been
processed, and the port is in a `Closed` state, there are no other
references to the `req_send` port than the one removed in this
commit.
2. All the references to `to_worker_send` channel are dropped. When
receiving a `Message`, the `SubSocket` worker clones this `Sender`
from an input worker's **Connected** state. Therefore if the input
worker is in the **Closed** state, all references to the `Sender`
will be dropped once the outstanding messages from the socket have
been sent.
Thus, by dropping the reference to the `req_send` channel inside the
input port worker's thread, and after it processes the outstanding
sends, no other thread is available to get a reference to the `Sender`
channels and the loop is able to exit cleanly
|
To run tests with full tracing output: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Currently CI fails due to this PR's new dependency on |
Merged
User344
reviewed
Dec 5, 2024
There was a problem hiding this comment.
This file is auto-generated. Maybe it makes more sense to put it in generated/-like directory and add it to .gitignore?
There was a problem hiding this comment.
I explicitly configure prost-build in build.rs to output the generated files to src/ as by default they go to the build directory (target/.../) and are imported with include!(concat!(env!("OUT_DIR"), "/your.proto.package.rs")).
So unless we have a preference against it, I'd place this in src/ and commit the generated file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.