Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional components #249

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optional components #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
defd227
update package-lock.json
aash1999 Sep 18, 2022
b831c28
resume button conditional rendering
aash1999 Sep 22, 2022
6accb50
conditional rendering of star me On github button
aash1999 Sep 22, 2022
1fa83ca
Update package-lock.json
aash1999 Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/containers/greeting/Greeting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,17 @@ export default function Greeting(props) {
{greeting.subTitle}
</p>
<SocialMedia theme={theme} />
<div className="portfolio-repo-btn-div">
<Button
text="⭐ Star Me On Github"
newTab={true}
href={greeting.portfolio_repository}
theme={theme}
className="portfolio-repo-btn"
/>
</div>
{greeting.showStarMebutton ? (
<div className="portfolio-repo-btn-div">
<Button
text="⭐ Star Me On Github"
newTab={true}
href={greeting.portfolio_repository}
theme={theme}
className="portfolio-repo-btn"
/>
</div>
) : null}
{/* <div className="button-greeting-div">
<Button text="Contact me" href="#contact" />
<Button text="See my resume" newTab={true} href={greeting.resumeLink} />
Expand Down
18 changes: 10 additions & 8 deletions src/pages/contact/ContactComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,16 @@ class Contact extends Component {
{ContactData["description"]}
</p>
<SocialMedia theme={theme} />
<div className="resume-btn-div">
<Button
text="See My Resume"
newTab={true}
href={greeting.resumeLink}
theme={theme}
/>
</div>
{contactPageData.isResumeDownloadable ? (
<div className="resume-btn-div">
<Button
text="See My Resume"
newTab={true}
href={greeting.resumeLink}
theme={theme}
/>
</div>
) : null}
</div>
</div>
</Fade>
Expand Down
2 changes: 2 additions & 0 deletions src/portfolio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const greeting = {
"https://drive.google.com/open?id=1XYpYhLeqCdyx_q6l0bQoC7RgwQjAjXPf",
portfolio_repository: "https://github.com/ashutosh1919/masterPortfolio",
githubProfile: "https://github.com/ashutosh1919",
showStarMebutton: true, // change it to true/false to show/hide Star Me On Github button
};

const socialMediaLinks = [
Expand Down Expand Up @@ -720,6 +721,7 @@ const contactPageData = {
title: "Phone Number",
subtitle: "+91 8320758513",
},
isResumeDownloadable: true, // change it to true/false to show/hide resume download button
};

export {
Expand Down