-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update privacy info #419
Update privacy info #419
Conversation
<string>NSPrivacyAccessedAPICategoryUserDefaults</string> | ||
<key>NSPrivacyAccessedAPITypeReasons</key> | ||
<array> | ||
<string>CA92.1</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CA92.1 is defined as:
"Declare this reason to access user defaults to read and write information that is only accessible to the app itself."
which doesn't seem right as the code doesn't access UserDefaults. Is there a more appropriate value to use, or can the array be empty if none apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to apple documentaion we can't keep empty array for below key's , If we are not using in our framework better remove instead of keeping as empty.
NSPrivacyTrackingDomains
NSPrivacyCollectedDataTypes
NSPrivacyAccessedAPITypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adzerjitchii @fxwx23 @SethBaldwin @closure11 @tommyming @lpbas @mmackowiak @marcuseckert As previous contributors to this topic, do you have any thoughts/opinions on this PR? |
Given what's stated in documentation:
and the fact |
If it stays as it is we receive a warning when uploading the app into the store, saying that file is not valid |
I think I introduced a confusion, to rephrase - current state, therefore what's in version |
Thanks for the tag @ashleymills! One possible cause I could think of is the path of the privacy manifest in Just ping me if there are any problem related to this. |
Greetings, do we have any update on this? What should we do to avoid having this warning from apple? |
Hello folks, any updates here? |
I merged in #420 which removes unused keys. Please try the latest release 5.2.4, if that doesn't work we'll try something else |
This PR fixes PrivacyInfo.xcprivacy file.