Sports Service #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/main.go: • Added endpoint definition for sports events requests. • Registered sports handler to the newly created gRPC endpoint. api/proto/sports: • Defined sports service ListEvents request. sports: • Created sports service implementation which allows for retrieval of sporting events via front facing API handler.
• Updated base docs to include sports service.
• Added test suite to test events functionality. db.go, events.go: • Added initialisation, insertion and clear functions for use in test suite.
• Update README.md with building, command line and testing sections.
• Switch testing header with directory structure to improve flow.
• Provide example of API server interaction. • Document seed command line parameter. main.go, events.go: • Allow for seeding of database on startup. events_test.go: • Update calls to `eventsRepo.Init` to disable seeding.
• Updated README.me with changes to events interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a sport service which interfaces with the API system to provide list requests (with optional filtering).