Single Race Lookup #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racing.proto: • Defined GetRace request which accepts the identifier of the race. queries.go: • Defined query for `getRace` requests. races.go: • Implemented `Get` function which returns a single race and optionally an error. racing.go: • Added racing interface and implementation for accessing racesRepo.
• Describe `id` parameter. races.go: • Describe return value for Get function.
• Provide comment for GetRaceRequest use case.
• Added test case for `Get` request. races.go: • Fixed compilation error due to bad merge.
• Document introduction of `GetRace` rpc call.
• Fixed invalid testType of "db" for races_test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description###
Allow for a single race lookup by ID.
Purpose
In some cases, it is not necessary to use a bulk lookup like list-races, instead, only needing to fetch a single ID. This P/R implements this behaviour.