Status Field for Race Response #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racing.proto: • Defined enum `Status` which reflects if a race is open or closed. races.go: • If the advertised start time is in the past, the race will be marked as "CLOSED", else, the race will indicate an "OPEN" status.
• Describe purpose of `status` response field.
• Added test case for status flag when returning race. races.go: • Obey guidelines for error messages (lowercase, no fullstops). go.mod: • Bump go version. db.go: • Remove deprecated package `ptypes.TimestampProto`.
• Detail the introduced status flag.
• Fixed invalid testType of "db" for races_test.
• Fixed compilation error due to changes to `racesRepo.Init()` changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a flag which indicates whether a race is open or closed.