Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering Filter #2

Open
wants to merge 14 commits into
base: feat-visibility-filter
Choose a base branch
from
Open

Commits on Aug 17, 2021

  1. Race List --

    racing.proto:
    • Added optional string parameter `order_by` as per Google design spec[1].
    races.go:
    • Changed `List` funct to accept ListRacesRequest param - this is required for accessing parameters outside of the filter.
    • Added function `applyOrdering` which appends ORDER BY statement. By default it orders by `advertised_start_time` but also allows for custom ordering.
    • Added function `toOrderBySql` which converts unvalidated external input for order by query and converts to a safe SQL format.
    ashleyjlive committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    d4d21f5 View commit details
    Browse the repository at this point in the history
  2. Update races.go

    Correct out-of-date naming for RacesRepo interface List function.
    ashleyjlive authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    0f53b3a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Configuration menu
    Copy the full SHA
    f91463d View commit details
    Browse the repository at this point in the history
  2. racing.proto:

    • Update order by comment to describe usage.
    ashleyjlive committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    767e3c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Configuration menu
    Copy the full SHA
    b221b21 View commit details
    Browse the repository at this point in the history
  2. races_test:

    • Added order by name test.
    ashleyjlive committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    5ed3015 View commit details
    Browse the repository at this point in the history
  3. races_test.go:

    • Expanded order by test case to ensure that multi space, multi fied sorting is obeyed.
    ashleyjlive committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    70097f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ec3d95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    248a269 View commit details
    Browse the repository at this point in the history
  6. racing/proto/README.md:

    • Added line for order by parameter detailing its purpose.
    ashleyjlive committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    65d987c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f5dd3d1 View commit details
    Browse the repository at this point in the history
  8. racing/db/races_test:

    • Fixed invalid testType of "db" for races_test.
    ashleyjlive committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    419457c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e7b668d View commit details
    Browse the repository at this point in the history
  10. Testing --

    • Fixed failing test cases due to compilation error with Init change.
    • Fixed database in use error due to test case access other test cases databases.
    ashleyjlive committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    86868e3 View commit details
    Browse the repository at this point in the history