-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordering Filter #2
Open
ashleyjlive
wants to merge
14
commits into
feat-visibility-filter
Choose a base branch
from
feat-ordering-filter
base: feat-visibility-filter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 17, 2021
-
racing.proto: • Added optional string parameter `order_by` as per Google design spec[1]. races.go: • Changed `List` funct to accept ListRacesRequest param - this is required for accessing parameters outside of the filter. • Added function `applyOrdering` which appends ORDER BY statement. By default it orders by `advertised_start_time` but also allows for custom ordering. • Added function `toOrderBySql` which converts unvalidated external input for order by query and converts to a safe SQL format.
Configuration menu - View commit details
-
Copy full SHA for d4d21f5 - Browse repository at this point
Copy the full SHA d4d21f5View commit details -
Correct out-of-date naming for RacesRepo interface List function.
Configuration menu - View commit details
-
Copy full SHA for 0f53b3a - Browse repository at this point
Copy the full SHA 0f53b3aView commit details
Commits on Aug 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f91463d - Browse repository at this point
Copy the full SHA f91463dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 767e3c3 - Browse repository at this point
Copy the full SHA 767e3c3View commit details
Commits on Aug 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b221b21 - Browse repository at this point
Copy the full SHA b221b21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ed3015 - Browse repository at this point
Copy the full SHA 5ed3015View commit details -
• Expanded order by test case to ensure that multi space, multi fied sorting is obeyed.
Configuration menu - View commit details
-
Copy full SHA for 70097f6 - Browse repository at this point
Copy the full SHA 70097f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec3d95 - Browse repository at this point
Copy the full SHA 8ec3d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 248a269 - Browse repository at this point
Copy the full SHA 248a269View commit details -
• Added line for order by parameter detailing its purpose.
Configuration menu - View commit details
-
Copy full SHA for 65d987c - Browse repository at this point
Copy the full SHA 65d987cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5dd3d1 - Browse repository at this point
Copy the full SHA f5dd3d1View commit details -
• Fixed invalid testType of "db" for races_test.
Configuration menu - View commit details
-
Copy full SHA for 419457c - Browse repository at this point
Copy the full SHA 419457cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7b668d - Browse repository at this point
Copy the full SHA e7b668dView commit details -
• Fixed failing test cases due to compilation error with Init change. • Fixed database in use error due to test case access other test cases databases.
Configuration menu - View commit details
-
Copy full SHA for 86868e3 - Browse repository at this point
Copy the full SHA 86868e3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.