Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tn/add groups #762

Merged
merged 108 commits into from
Mar 2, 2023
Merged

Tn/add groups #762

merged 108 commits into from
Mar 2, 2023

Conversation

TylerNoblett
Copy link
Collaborator

I've added a user group feature that allows system admins to create groups of users, and then system admins or operation admins can assign those groups to an operation. If a user is assigned to an operation via a group AND individually, the greater of the permission levels of the two will be granted.

Here's a video showing the system admin view:
https://user-images.githubusercontent.com/22867407/210581893-9ec21a42-ca37-4699-980c-82e93ac4e3dd.mov

Here's a video showing how to add a user via a group
https://user-images.githubusercontent.com/22867407/210582049-c0a6ac7f-77f9-422c-b097-237333ebcfb0.mov

Here's a video showing that the greater permission level is granted
https://user-images.githubusercontent.com/22867407/210582353-7758a9a4-82bd-4620-982e-14230b72cfbc.mov

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

JoelAtDeluxe
JoelAtDeluxe previously approved these changes Mar 1, 2023
Copy link
Collaborator

@JoelAtDeluxe JoelAtDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long, long time it took to get through this.

Overall, this looks fine. I think we can improve the add users to group query, and the deleting users from group query (into, hopefully, a single query, or at worst a group of queries (select from users, then delete where in) ). Personally, I think it's also worth dropping the pagination support on the backend for groups, and maybe just doing front-end only pagination.

With those two queries (and optionally the pagination) fixed, I think we'd be in a good place to merge.

jkennedyvz
jkennedyvz previously approved these changes Mar 1, 2023
@TylerNoblett
Copy link
Collaborator Author

TylerNoblett commented Mar 2, 2023

Sorry for the long, long time it took to get through this.

Overall, this looks fine. I think we can improve the add users to group query, and the deleting users from group query (into, hopefully, a single query, or at worst a group of queries (select from users, then delete where in) ). Personally, I think it's also worth dropping the pagination support on the backend for groups, and maybe just doing front-end only pagination.

With those two queries (and optionally the pagination) fixed, I think we'd be in a good place to merge.

Thanks for reviewing it Joel! No worries; it was pretty long 😬 I've modified both queries and am going to take a look at pagination right now!

@jkennedyvz jkennedyvz merged commit d7e7490 into main Mar 2, 2023
@TylerNoblett TylerNoblett deleted the tn/add_groups branch March 3, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role-based access
3 participants