-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request follow-up for #30: Example and Vignette runtime #56
Pull Request follow-up for #30: Example and Vignette runtime #56
Conversation
@jonathandroth Can you test the function on your mac? The tests are failing for OSX but not for Linux somehow. Just wanna double-check there isn't an issue. LMK and I'll merge. |
I ran test_base.R (I assume that's what you wanted?) and I get the following error: ── Error (~/Library/CloudStorage/Dropbox/HonestDiD_MauricioGithub/HonestDiD/tests/test_base.R:28:5): HonestDiD base ran with no errors ──
Error in reporter$stop_if_needed() : Test failed |
@jonathandroth Ok this is fixed. It seems sometimes it overflowed into a numerical zero but it was negative, so |
This addresses the comments here that the computing time for the examples, tests, and vignette are too long.
dontrun
do they don't run, cutting the runtime.HONESTDID_RUN_TESTS=1
is set, as suggested.vignette/precompute.R
script has all the vignette code and should be updated and re-run if the vignette ever changes. However, it's not included in the package build (see.Rbuildignore
).