Skip to content

Commit

Permalink
selenium support (#5)
Browse files Browse the repository at this point in the history
* selenium support

* Make sure R CMD CHECK passes

* Fix pkgdown site

* Fix R CMD CHECK workflow for selenium

* Use bigger shm size in GHA

* Use remote-debugging-port for Chrome and selenium

* Use dev version of selenium

* Fix installation of selenium

* Update documentation

* Fix test_selenider()

* Don't run chromote tests if we aren't testing chromote

* Skip scroll tests on GHA

* Make sure manual tests pass

* Fix selenider_test_session()
  • Loading branch information
ashbythorpe authored Nov 3, 2023
1 parent 7ebfd14 commit 146e1a6
Show file tree
Hide file tree
Showing 50 changed files with 1,332 additions and 689 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/R-CMD-check-selenium.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,24 @@ jobs:
R-CMD-check:
runs-on: ubuntu-latest

name: ${{ matrix.browser }}
name: ${{ matrix.browser }} - ${{ matrix.config.os }} (${{ matrix.config.r }})

strategy:
fail-fast: false
matrix:
config:
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}
browser: [chrome, firefox]

services:
selenium:
image: selenium/standalone-${{ matrix.browser }}:3.141.0
image: selenium/standalone-${{ matrix.browser }}:4.15.0-20231102
ports:
- 4444:4444
options: >-
--shm-size="2g"
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Suggests:
rmarkdown,
RSelenium,
rvest,
selenium (>= 0.1.2.9000),
shiny,
shinytest2,
showimage,
Expand All @@ -48,3 +49,5 @@ Config/Needs/website: rmarkdown
LazyData: true
VignetteBuilder: knitr
Language: en-GB
Remotes:
selenium=ashbythorpe/selenium-r
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export(attr_contains)
export(back)
export(close_session)
export(create_chromote_session)
export(create_rselenium_client)
export(create_selenium_client)
export(create_selenium_server)
export(current_url)
Expand Down
Loading

0 comments on commit 146e1a6

Please sign in to comment.