Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConditionGeneric.cs #52

Closed
wants to merge 1 commit into from
Closed

Conversation

hookSSi
Copy link
Contributor

@hookSSi hookSSi commented Mar 29, 2021

I think this is mistake...?

I think this is mistake
@ashblue
Copy link
Owner

ashblue commented Mar 29, 2021

Dang this one too (just fixed the generic action). Yeah that's wrong. A few things will need to be tweaked before you can merge.

Can you write a test that confirms this error? I think you should be able to adapt this test easily to your code. Which was written to prove the same issue with the generic action.

https://github.com/ashblue/fluid-behavior-tree/pull/42/files

You'll also need to recreate your commit using the commit guidelines in the link below. You should be able to rewrite your commit message. The easiest way would be to use the commit message generator tool built in npm run commit. You'll have to install Node.js first though if you haven't and run npm install to use the committer. Once that's valid the Travis CI tool will give a valid pass.

https://github.com/ashblue/fluid-behavior-tree#development-environment

Once that's all done I can automatically deploy a patch from your commit (I'll also add you via all contributors on the README.md). If you have any questions don't hesitate to ask (I super appreciate the MR).

PS I need to better document all this with a template whenever somebody creates a new PR. I added a ticket to do it so I don't forget. 😅

#53

@ashblue ashblue added the bug Something isn't working label Mar 29, 2021
@hookSSi
Copy link
Contributor Author

hookSSi commented Mar 30, 2021

Sorry to bother you.

The guidelines are perfect, but I am not good enough.

I will look at the guidelines and follow them.

@ashblue
Copy link
Owner

ashblue commented Apr 2, 2021

@hookSSi hey no worries 😄 I often just rewrite the MRs for people to meet all the standards so I appreciate this. Going to close this ticket in favor of your other MR #54

@ashblue ashblue closed this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants