Experimental AMD extensions #184
Conversation
| } | ||
| } | ||
| impl<'a> PhysicalDeviceWaveLimitPropertiesAmdBuilder<'a> { | ||
| pub fn next<T>(mut self, next: &'a mut T) -> PhysicalDeviceWaveLimitPropertiesAmdBuilder<'a> |
There was a problem hiding this comment.
I believe this should be &'a T right now, but if #183 merges then this is correct.
There was a problem hiding this comment.
Just leave it as it is right now.
Don't extensions need code in ash-sys anyway, for function signatures and struct types? Doesn't seem like this is any different to me. |
Yes it is not a real problem, we just have to move the "low level" part into |
msiglreith
changed the title
|
Should be ready now. I skipped the high level API as I'm not sure if it would be of much worth for now |
|
A bit, mostly trying to make sense out of the exposed counters as 90% of these are not documented and GCN generation specific 😅 |
|
bors r+ |
184: Experimental AMD extensions r=MaikKlein a=msiglreith Addresses #178 (comment) Not fully supports all parts of the APIs, just trying to get some general feedback if this meets the expected structuring. Co-authored-by: msiglreith <[email protected]>
Addresses #178 (comment)
Not fully supports all parts of the APIs, just trying to get some general feedback if this meets the expected structuring.