Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function to extend limited objects and prevent duplicate object names during extending hooks #9

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

shahryarjb
Copy link
Collaborator

@shahryarjb shahryarjb commented Jan 8, 2025

In this PR, I have tried to address some essential requirements that were missing. Additionally, I aimed to guide the user-facing functions towards a continuous model, ensuring that duplicate imports or extensions are automatically ignored and the code is generated seamlessly.

Example based on mishka-group/mishka_chelekom#181

// assets/vendor/components.js

import CopyMixInstallationHook from "./mixCopy.js";
import CopyColorInstallationHook from "./colorCopy.js";

const Components = {
  CopyMixInstallationHook,
  CopyColorInstallationHook,
};

export default Components;

Note:
I have not changed the version to allow any necessary build adjustments to be made. If this needs to be addressed, please let me know so I can update it, or feel free to handle it yourself.

Please squash this pull request as it contains too many commits.

@shahryarjb shahryarjb added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 8, 2025
@shahryarjb shahryarjb requested a review from zachdaniel January 8, 2025 14:17
@shahryarjb shahryarjb self-assigned this Jan 8, 2025
@zachdaniel zachdaniel merged commit e341ab0 into ash-project:main Jan 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants