Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add options to disable atomic actions and error expressions #464

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: add options to disable atomic actions and error expressions #464

merged 4 commits into from
Jan 16, 2025

Conversation

barnabasJ
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@barnabasJ barnabasJ self-assigned this Jan 16, 2025
@barnabasJ barnabasJ added the enhancement New feature or request label Jan 16, 2025
@barnabasJ barnabasJ requested a review from zachdaniel January 16, 2025 14:56
zachdaniel
zachdaniel approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the dbg though :)

@zachdaniel
Copy link
Contributor

Actually @barnabasJ we should make this a repo callback, not compile time config.

@barnabasJ
Copy link
Contributor Author

Actually @barnabasJ we should make this a repo callback, not compile time config.

Ah, make sense. Could be you only want to do this for a specific repo

@barnabasJ barnabasJ requested a review from zachdaniel January 16, 2025 16:12
@barnabasJ
Copy link
Contributor Author

CI fails because https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@zachdaniel zachdaniel merged commit 0f38bf2 into main Jan 16, 2025
51 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel Awaiting requested review from zachdaniel

Assignees

@barnabasJ barnabasJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel