Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle regex match correctly #460

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: handle regex match correctly #460

merged 2 commits into from
Jan 14, 2025

Conversation

barnabasJ
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@barnabasJ barnabasJ self-assigned this Jan 13, 2025
@barnabasJ barnabasJ added the bug Something isn't working label Jan 13, 2025
@barnabasJ barnabasJ requested a review from zachdaniel January 13, 2025 23:33
@zachdaniel
Copy link
Contributor

looks like a dialyzer issue remains

@barnabasJ
Copy link
Contributor Author

looks like a dialyzer issue remains

That was is already in main. I'll merge this in to get unblocked. I can take a look at the dialyzer issue later today.

@barnabasJ barnabasJ merged commit 12f914d into main Jan 14, 2025
51 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@barnabasJ barnabasJ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel