486 add linux to flat hub

[Thorian1te]

No description provided.

[beemdvp]

Excited to see this release 🎉

[dynst]

Shouldn't the application ID be something like com.asgardex.asgardex-desktop? asgardex.com is the project's domain, and the Flathub rules also say not to end an ID with .desktop.

https://www.asgardex.com/

https://docs.flathub.org/docs/for-app-authors/requirements#application-id

• The ID must not end in generic terms like .desktop or .app. It's fine to repeat the application name in such cases.

https://docs.flathub.org/docs/for-app-authors/requirements#control-over-domain-or-repository

• The domain must be directly related to the project or the application being submitted and the author or the developer or the project must have control over the domain. The corresponding URL must be reachable over HTTP(S).

[dynst]

org.freedesktop.Platform only has 'a maintenance period of two years.' 22.08 is already EOL.

https://docs.flatpak.org/en/latest/available-runtimes.html#freedesktop

https://freedesktop-sdk.gitlab.io/documentation/updating-sdk/release-notes/

[dynst]

Instead of redundantly installing and bundling Electron, is it possible to just use the already-packaged Electron BaseApp, with the steps outlined here?

https://docs.flatpak.org/en/latest/electron.html

[Thorian1te]

yeah definitely

[dynst]

There's actually no reason this needs read/write access to the whole home directory, is there? All user-imported files just go through the file picker portal, right?

https://docs.flatpak.org/en/latest/sandbox-permissions.html#filesystem-access

Since flatpak gives the sandboxed app its own $XDG_CONFIG_HOME, if Electron uses $XDG_CONFIG_HOME to determine the appData directory, everything should just work without any permissions or code changes at all: STORAGE_DIR will end up as ~/.var/app/com.asgardex.asgardex-desktop/config/ASGARDEX/storage/.

https://www.electronjs.org/docs/latest/api/app#appgetpathname

asgardex-desktop/src/main/api/const.ts

Lines 7 to 8 in 74c1ddf

	export const APP_DATA_DIR = path.join(app?.getPath('appData') ?? './testdata', APP_NAME)
	export const STORAGE_DIR = path.join(APP_DATA_DIR, 'storage')

[Thorian1te]

you are more than welcome to help get this PR completed. As displayed this is not my area of expertise 😮‍💨.

[dynst]

I would but I only have read-only permissions here 😅

Just deleting the entire --filesystem=home line should be fine though.

[dynst]

There's an issue with dependencies: the line that runs yarn install --immutable looks like it fails in the Fetch step, because in the build sandbox there is no network access. The only way to download dependencies is to declaratively specify them as sources, which get downloaded before the build sandbox runs.

Other projects like yarn-flatpak-demo and DOS Browser additionally make use of the obsolete yarn --offline option and the yarn-offline-mirror config. But their repos use Yarn Classic, while Asgardex uses Yarn Modern, which removed those, so copying the same solution wouldn't work here.

(YARN_ENABLE_OFFLINE_MODE=1 looks like it might be relevant? But it doesn't solve the problem.)

The right solution is probably using a tool called flatpak-node-generator to pin all the dependencies, which get specified as 'sources' in the syntax that flatpak understands (generated-sources.json), so that flatpak-builder will simply download all your dependencies beforehand.

[dynst]

Looking into it, combining Yarn & flatpak is actually currently hard to do 'the right way,' building from source, because the existing tooling only supports Yarn Classic (Yarn 1).

There's been a PR open since 2021 that'll add support for Yarn 2 and Yarn 3, but even it doesn't add support for Yarn 4 (what asgardex currently uses): flatpak/flatpak-builder-tools#252 (comment)

The workaround would be to have flatpak download already-built .js/.css bundles, copy them where the Electron BaseApp will run them, and skip any real build process entirely (for now).