Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible bug in handleTokenResponse method #258

Merged

Conversation

DonOmalVindula
Copy link
Contributor

@DonOmalVindula DonOmalVindula commented Oct 25, 2024

Purpose

$subject

This removes the await statement in the if condition as there is a possibility for the await statement to not work properly when it is evaluated in a conditional statement.

Related Issues

Related PRs

Checklist

  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

pavinduLakshan
pavinduLakshan previously approved these changes Oct 25, 2024
dasuni-30
dasuni-30 previously approved these changes Oct 25, 2024
@pavinduLakshan pavinduLakshan merged commit 93c907b into asgardeo:master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants