Fix warning about version >= 3.41.0 requirement #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current message states that SQLite version needs to be below 3.41.0 for 2nd parameter when in fact it needs to be at or above. * Change messaging to be at or above as that is the requirement set in the parent if statement
|
Thank you for the great extension. I noticed an issue when setting this up with an older version of SQLite (3.38.x). I received the error but it seemed like it is intended to state above. This was confirmed when I upgraded my SQLite version to 3.41.0 and the extension worked as expected. Thanks again 🍻 |
ankon
reviewed
Jun 15, 2023
| @@ -813,7 +813,7 @@ static int vssIndexFilter( | |||
| // https://sqlite.org/forum/info/6b32f818ba1d97ef | |||
| else if(sqlite3_libversion_number() < 3041000) { | |||
| sqlite3_free(pVtabCursor->pVtab->zErrMsg); | |||
| pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only support vss_search_params() as a 2nd parameter for SQLite versions below 3.41.0"); | |||
| pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only support vss_search_params() as a 2nd parameter for SQLite versions at or above 3.41.0"); | |||
There was a problem hiding this comment.
While you're there anyways:
Suggested change
| pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only support vss_search_params() as a 2nd parameter for SQLite versions at or above 3.41.0"); | |
| pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only supports vss_search_params() as a 2nd parameter for SQLite versions at or above 3.41.0"); |
There was a problem hiding this comment.
Thanks for taking a look. Both changes are updated in a new PR to make things cleaner to review. See #72
mkly
added a commit
to mkly/sqlite-vss
that referenced
this pull request
Jul 1, 2023
Current message states that SQLite version needs to be below 3.41.0 for 2nd parameter when in fact it needs to be at or above. * Change messaging to be at or above as that is the requirement set in the parent if statement * Update minor grammatical issue Closes asg017#11
|
Closing in favor of #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current message states that SQLite version needs to be below 3.41.0 for 2nd parameter when in fact it needs to be at or above.