bug: give full path to asdf #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some use cases, asdf is not yet added to PATH. Determine ASDF_DIR and give full pathname of asdf in bin/install.
Stratus3D
reviewed
Aug 11, 2023
There was a problem hiding this comment.
If asdf is properly installed this shouldn't be necessary. I suggest you look at your development environment or your install script and see if you can correct things so asdf is on the path.
@augustobmoura can you take a look at this? Generally, asdf plugins should not turn around and invoke asdf like this. I imagine this is probably necessary in this case, but it should be avoided.
|
@zrusilla can you be more specific to which cases would asdf not be on PATH? From a glance, I believe @Stratus3D is correct, a correct instalation of asdf should always have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some use cases, such as scripted install, asdf is not yet added to PATH.
Determine ASDF_DIR and give full pathname of asdf in bin/install.