-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/theme-updates #1897
docs/theme-updates #1897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few comments/questions.
Poking around the docs I also noticed that the left menu is no longer collapsing the autogenerated API documentation. EDIT: same for non-autodoc docs comparing |
The left menu on the old/current theme is visible on the right hand side under "On this page" in the new theme. The left sidebar is a now a Toc Tree of the pages, while the rather than the contents of the page you're viewing (which is now on the right). The existing theme displays a mix of the currently viewed page's headings as well as other pages underneath it - so that change here is putting pages on left sidebar, current page contents on the right. |
Can we get something more similar to the old behavior back with the new theme? The goal is to preserve the TOC nesting that was previously shown on the left menu. To provide an example to explain the motivation:
Whereas with the current configuration in this PR:
|
I think so let me work on that |
I've tried setting up User Api to include its 3 sections in the left-hand TOC. In order to do this however I needed to split these up into their own pages. (Sphinx's toctree directive only allows references to actual pages, not page sections.) Let me know what you think and if you'd like to keep this or if I should revert back to how it was: https://asdf--1897.org.readthedocs.build/en/1897/asdf/user_api/asdf_package.html (note you may need to refresh page/clear cookies or open in incognito window) |
One minor comment about the version/release in the sphinx conf then this is good to go. A TBD docs cleanup seems worthwhile to take full advantage of the new theme but it makes sense to me to have that in follow-up PRs (since those will involve content changes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all your work on this.
Description
This PR updates documentation configuration options to make Read the Docs look and feel consistent with other ASDF subprojects.
Tasks
pre-commit
on your machinepytest
on your machineno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pagenews fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: bug fixchanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.general.rst
: infrastructure or miscellaneous change