This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Refactor the image zoom component to avoid the use of deprecated methods #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
componentWillMount
andcomponentWillReceiveProps
are deprecated lifecycle methods and should be avoided. This PR offers to move thecomponentWillMount
part to the constructor (which has the exact same effect), and moves thecomponentWillReceiveProps
part tocomponentDidUpdate
, which is safe since the function performs comparison between props to detect any change (thus the additional calls will not result in unexpected behaviour).Diff kinda messed up because I removed one indentation as I moved the pan responder to the constructor.
Fixes #111 and closes #114.
After merging this PR, consider releasing a new version of this module as well as https://github.com/ascoders/react-native-image-viewer to fix ascoders/react-native-image-viewer#360