-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable document model in sycamore.query + query-ui improvements #884
Open
baitsguy
wants to merge
19
commits into
main
Choose a base branch
from
doc_model_sycamore_query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baitsguy
changed the title
Enable document model in sycamore.query
Enable document model in sycamore.query + QueryUI improvements
Oct 8, 2024
baitsguy
changed the title
Enable document model in sycamore.query + QueryUI improvements
Enable document model in sycamore.query + query-ui improvements
Oct 8, 2024
mdwelsh
reviewed
Oct 8, 2024
Co-authored-by: Matt Welsh <[email protected]>
Co-authored-by: Matt Welsh <[email protected]>
Co-authored-by: Matt Welsh <[email protected]>
mdwelsh
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes all over to support doc model and usability for sycamore query.
reconstruct_document
in db scans anduse_elements
in llm map opsextract_entity
whenuse_elements
is Truetrace_dir
providedlocal_mode
note: The queries have only been manually tested so it's possible we'll have to make more changes. Might need UI changes if we want to show/highlight elements within a doc that passed a filter/opensearch query