Get llm_filter to support document structure + similarity sorting for elements #876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Support document model in llm_filter and some performance improvements
llm_filter will work on a DocSet made of original Documents (i.e. pre-exploded state) when using
use_elements=True
keep_none
flag to dictate behavior for a missing property valueNone of these are perfect but they align with the use cases we have so far and can keep iterating.
2. Sorted elements returned by OpenSearchReader in reconstructed documents
Use element.element_index field to sort elements when reconstructing a document. Does an explicit sort after each reconstruction which is okay based on the magnitude of data.
Note: the
ignore_doc_structure
flag is to prevent current usage from breaking, once we update other code to use the document model we can remove/flip it