Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #637

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Conversation

rohanbabbar04
Copy link
Collaborator

@rohanbabbar04 rohanbabbar04 commented Jan 27, 2025

Description

  • Remove fixed dependencies from requirements.(Would be better for future versions of python).

Checklist

  • Code style is correct (follows ruff and black guidelines)
  • All Tests pass

@rohanbabbar04
Copy link
Collaborator Author

  • I think we should get rid of the fixed dependencies (==) which will make it easier to migrate to python3.13.
  • Don't really know why this error is coming(could be due to some minor adjustments in random values)

@aloctavodia
Copy link
Contributor

aloctavodia commented Jan 27, 2025

We can get small differences like this due to changes from one scipy version to the other.
Dependencies can be tricky. If we leave them unfixed, users may get errors or missing features on new installations just because a dependency got updated, but untested on our side. We should probably stick to this https://scientific-python.org/specs/spec-0000/

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (f25da81) to head (1aaf9f9).
Report is 94 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f25da81) and HEAD (1aaf9f9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f25da81) HEAD (1aaf9f9)
3 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   82.23%   74.27%   -7.96%     
==========================================
  Files         101      105       +4     
  Lines        8020     8709     +689     
==========================================
- Hits         6595     6469     -126     
- Misses       1425     2240     +815     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohanbabbar04
Copy link
Collaborator Author

rohanbabbar04 commented Jan 27, 2025

We can get small differences like this due to changes from one scipy version to the other. Dependencies can be tricky. If we leave them unfixed, users may get errors or missing features on new installations just because a dependency got updated, but untested on our side. We should probably stick to this https://scientific-python.org/specs/spec-0000/

Yup, I have updated to scipy>=1.10, <1.15 which seems to be good, our tests work fine as well.
I went through the release notes of scipy they seem to have support for python3.13 in release version > 1.14

@rohanbabbar04 rohanbabbar04 changed the title Remove fixed dependencies Update dependencies Jan 27, 2025
@rohanbabbar04
Copy link
Collaborator Author

@aloctavodia, this is ready to be reviewed.
With this it should be possible to incorporate python3.13 without much fuss :)

@aloctavodia aloctavodia merged commit 5cfb898 into arviz-devs:main Jan 29, 2025
3 checks passed
@rohanbabbar04 rohanbabbar04 deleted the fixed-dependencies branch January 29, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants