-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow infilling when target areas already have some required activities within them #49
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-infill-from-points #49 +/- ##
==========================================================
+ Coverage 82.87% 83.74% +0.86%
==========================================================
Files 5 5
Lines 508 529 +21
Branches 123 130 +7
==========================================================
+ Hits 421 443 +22
+ Misses 61 60 -1
Partials 26 26 ☔ View full report in Codecov by Sentry. |
Yeah this is nice - a good way to limit how many areas will be affected. Though I think from a user perspective, you are more likely to be a bit more binary in your desire for infilling. A likely scenario for a study area might be that you have say the TE region, but want to infill a local area to real levels. An ability to point this method to a boundary file and say outside the study area use the method for just infilling completely empty areas, and then within the boundary infill all landuse up to the levels of the reference dataset (regardless of what % completion each area is in relation to the reference dataset) |
This is independent of trying to meet a specific regional target and I think even if you had that target you wouldn't want to attempt to infill areas that already have 90% of the residential landuse filled with relevant activities, so a threshold for infilling would still be a good idea. |
Yeah I guess when enabling regional targets it would be useful to specify different thresholds for a study area vs outside study area. |
Added similar images as in #46 . |
Fixes #47
Focus is only on point 1 of #47.
Rather than set a binary flag to allow / disallow infilling in already occupied areas, I've made it a threshold fraction. This is based on percentage area occupied and has required me to expand any point activities to polygons. I chose to use the same sizing as would be used for infilling to approximate polygons for these points. Would be good to get an opinion on whether there is a better approach.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.