Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow infilling when target areas already have some required activities within them #49

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

brynpickering
Copy link
Contributor

Fixes #47

Focus is only on point 1 of #47.

Rather than set a binary flag to allow / disallow infilling in already occupied areas, I've made it a threshold fraction. This is based on percentage area occupied and has required me to expand any point activities to polygons. I chose to use the same sizing as would be used for infilling to approximate polygons for these points. Would be good to get an opinion on whether there is a better approach.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Tests added to cover contribution
  • Documentation updated

@brynpickering brynpickering changed the base branch from main to add-infill-from-points April 4, 2024 20:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.22222% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.74%. Comparing base (dc4eb54) to head (1eb198e).

Files Patch % Lines
src/osmox/build.py 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           add-infill-from-points      #49      +/-   ##
==========================================================
+ Coverage                   82.87%   83.74%   +0.86%     
==========================================================
  Files                           5        5              
  Lines                         508      529      +21     
  Branches                      123      130       +7     
==========================================================
+ Hits                          421      443      +22     
+ Misses                         61       60       -1     
  Partials                       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@val-ismaili
Copy link
Contributor

Yeah this is nice - a good way to limit how many areas will be affected. Though I think from a user perspective, you are more likely to be a bit more binary in your desire for infilling. A likely scenario for a study area might be that you have say the TE region, but want to infill a local area to real levels. An ability to point this method to a boundary file and say outside the study area use the method for just infilling completely empty areas, and then within the boundary infill all landuse up to the levels of the reference dataset (regardless of what % completion each area is in relation to the reference dataset)

@brynpickering
Copy link
Contributor Author

This is independent of trying to meet a specific regional target and I think even if you had that target you wouldn't want to attempt to infill areas that already have 90% of the residential landuse filled with relevant activities, so a threshold for infilling would still be a good idea.

@val-ismaili
Copy link
Contributor

This is independent of trying to meet a specific regional target and I think even if you had that target you wouldn't want to attempt to infill areas that already have 90% of the residential landuse filled with relevant activities, so a threshold for infilling would still be a good idea.

Yeah I guess when enabling regional targets it would be useful to specify different thresholds for a study area vs outside study area.

Base automatically changed from add-infill-from-points to main April 5, 2024 14:13
@brynpickering
Copy link
Contributor Author

Added similar images as in #46 .

@brynpickering brynpickering merged commit bfa3aaa into main Apr 5, 2024
14 checks passed
@brynpickering brynpickering deleted the infill-without-exclusivity branch April 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infill in landuse areas that have existing facilities
3 participants