Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run all pre-commit hooks #329

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

arunanshub
Copy link
Owner

@arunanshub arunanshub commented Apr 22, 2024

Summary by CodeRabbit

  • Chores
    • Removed the ruff command from the linting step in the CI workflow.
    • Updated the configuration for coverage reporting in the CI workflow.
    • Removed the Black formatter from the pre-commit configuration.

Copy link

coderabbitai bot commented Apr 22, 2024

Walkthrough

The recent updates involve streamlining the codebase by removing certain tools and configurations. Specifically, the ruff command was removed from the linting process, the Black formatter was eliminated from the pre-commit setup, and a parameter in the Coveralls configuration was updated for clarity.

Changes

Files Changes
.github/.../ci.yml Removed ruff from linting step; updated path-to-lcov to file in Coveralls config.
.pre-commit-config.yaml Removed Black formatter hook and its configuration.

Possibly related issues

  • Dependency Dashboard WebBin#4: The removal of ruff from linting steps might align with their objective to manage dependencies and streamline updates, though the connection is indirect.
  • Dependency Dashboard git-credential-netconf#4: The simplification of pre-commit hooks, such as the removal of Black, could be considered in line with their updates to pre-commit configurations.

🐇💻
In the burrow of code, a change did spring,
Where ruff and Black no longer sing.
A simpler path, the rabbits found,
With cleaner hops on coding ground.
🌟📜🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between cdf269a and 0c28543.
Files selected for processing (2)
  • .github/workflows/ci.yml (2 hunks)
  • .pre-commit-config.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .pre-commit-config.yaml
Additional comments not posted (2)
.github/workflows/ci.yml (2)

43-43: The removal of the ruff command is not directly visible here, but it's implied by the use of pre-commit run --all. Ensure that the .pre-commit-config.yaml reflects this removal to avoid any discrepancies.


79-79: The update of the path-to-lcov parameter to file in the Coveralls GitHub Action configuration appears correct. Please ensure this aligns with the latest Coveralls documentation to prevent any issues with coverage report uploads.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arunanshub arunanshub merged commit 08a1ee8 into master Apr 22, 2024
15 checks passed
@arunanshub arunanshub deleted the dev/pre-commit-ruff-format-hook branch April 22, 2024 16:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8787437938

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.398%

Totals Coverage Status
Change from base Build 8787323455: 0.0%
Covered Lines: 64
Relevant Lines: 184

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants