Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continue reading link #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amorphic
Copy link

@amorphic amorphic commented Jan 2, 2019

This PR:

  1. Adds a "Continue Reading" link at the bottom of each article's summary. This allows the reader to click directly through to the full article from the end of the summary rather than scroll back up to the Headline. The link is styled using the same "button" style as the article tags.

  2. Updates the "Comments" link to the same style as the "Continue Reading" link and places them side-by-side to conserve vertical space:

image

@arulrajnet
Copy link
Owner

@amorphic Thanks for your PR. The buttons are not properly formatted when I tried with attila-demo source code
image

@amorphic
Copy link
Author

amorphic commented Jan 6, 2019

Thanks for checking @arulrajnet. The buttons render correctly on my blog so I assumed they were good to go.

I'll looking into what's going wrong with the attila demo blog and update the PR accordingly.

1 similar comment
@amorphic
Copy link
Author

amorphic commented Jan 9, 2019

Thanks for checking @arulrajnet. The buttons render correctly on my blog so I assumed they were good to go.

I'll looking into what's going wrong with the attila demo blog and update the PR accordingly.

Allows a reader to click directly through to the article from the
end of the summary.
@amorphic
Copy link
Author

@arulrajnet I've updated the PR and tested against my blog and the Attila demo site:

image

The change is actually much cleaner since the update too. Please let me know if you want any other changes.

@sio
Copy link
Contributor

sio commented Jul 31, 2019

Are these links optional? I'd like to have the ability to opt out of rendering them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants