-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner version info #1298
Merged
Merged
Cleaner version info #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated housekeeping)
… unrelated housekeeping)
github-actions
bot
added
vm
Issues related to the Virtual Machine implementation
library
Issues related to the standard library
helpers
Issues related to Helper modules
labels
Nov 11, 2023
drkameleon
added
enhancement
New feature or request
command line
Issues related to Arturo's command-line and options
vm
Issues related to the Virtual Machine implementation
library
Issues related to the standard library
helpers
Issues related to Helper modules
and removed
vm
Issues related to the Virtual Machine implementation
library
Issues related to the standard library
helpers
Issues related to Helper modules
labels
Nov 11, 2023
Ready to merge! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command line
Issues related to Arturo's command-line and options
enhancement
New feature or request
helpers
Issues related to Helper modules
library
Issues related to the standard library
vm
Issues related to the Virtual Machine implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, if we open the REPL it shows complete version information: main version + build + system (+ build timestamp).
It wouldn't be bad since the main information (everything but the timestamp, which is not that useful + it creates some compile-time constants issues) should also be shown when doing
arturo --version
.Also, we have to normalize the way a couple of build details are displayed (e.g. it shows to me "macosx" - while the official name of the OS is "macOS" since 2016...)
Type of change