Merge pull request #1654 from arturo-lang/upgrade-Nim-to-2.0.6

Upgrade Nim to 2.0.8
arturo-lang · Jul 12, 2024 · d142954 · d142954
2 parents c304297 + d505184
commit d142954
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -51,7 +51,7 @@ jobs:
                 arch: ${{ matrix.arch }}
                 src: ${{ github.ref }}
                 metadata: ${{ env.BRANCH_NAME }}-${{ github.sha }}
-
+ 
             - if: (matrix.mode != 'safe' && matrix.mode != 'web') && (matrix.os != 'ubuntu-latest' || matrix.arch != 'arm64')
               name: Run tests (Old)
               run: |

diff --git a/src/vm/stack.nim b/src/vm/stack.nim
@@ -42,7 +42,12 @@ var
 
 # Main stack
 
-template push*(v: Value) = 
+proc push*(v: Value) = 
+    # TODO(Stack/push) performance enhancements?
+    #  this was a `template` that we converted into a `proc` so that
+    #  we could get the whole project to compile with Nim 2.0.8
+    #  does it make any sense performance-wise?
+    #  labels: vm, stack, enhancement, performance, benchmark
     ## push given value onto the stack
     hookProcProfiler("stack/push"):
         Stack[SP] = v

diff --git a/tests/unittests/lib.comparison.res → tests/unittests/lib.comparison_res b/tests/unittests/lib.comparison.res → tests/unittests/lib.comparison_res
diff --git a/version/build b/version/build
@@ -1 +1 @@
-3151
+3190