Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 'destroy()' propagating to all appended agility objects #58

Merged
merged 2 commits into from
Nov 19, 2011
Merged

Implemented 'destroy()' propagating to all appended agility objects #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8165558
Implemented 'destroy()' propagating to all appended agility objects p…
tristanls Nov 17, 2011
9f9e752
Used this._container.empty() instead of .each()
tristanls Nov 19, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions agility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,9 @@

// Triggered upon removing self
_destroy: function(event){
// destroy any appended agility objects
this._container.empty();
// destroy self
this.view.$().remove();
},

Expand Down
35 changes: 35 additions & 0 deletions test/public/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,41 @@
equals( ob.view.$( 'span' ).last().html(), 'postHookEventLastLast', 'last postHook event fired last');
});

test("Destroy propagates to children", function() {
var destroyTriggered = false;
var childDestroyTriggered = false;
var grandchildDestroyTriggered = false;
var greatgrandchildDestroyTriggered = false;
var obj = $$({}, '<div/>', {
'destroy': function() {
destroyTriggered = true;
}
});
var child = $$({}, '<div/>', {
'destroy': function() {
childDestroyTriggered = true;
}
});
var grandchild = $$({}, '<div/>', {
'destroy': function() {
grandchildDestroyTriggered = true;
}
});
var greatgrandchild = $$({}, '<div/>', {
'destroy': function() {
greatgrandchildDestroyTriggered = true;
}
});
obj.append( child );
child.append( grandchild );
grandchild.append( greatgrandchild );
obj.destroy();
ok(destroyTriggered, "destroy triggered");
ok(childDestroyTriggered, "child destroy triggered");
ok(grandchildDestroyTriggered, "grandchild destroy triggered");
ok(greatgrandchildDestroyTriggered, "great grandchild destroy triggered");
});

test("Extend controller syntax from four arguments (prototype, model, view, controller object)", function() {
var lbl = $$({}, '<span data-bind="label"/>');
var partial = $$({}, '<div/>', {
Expand Down