Merge pull request meshery#5245 from piyushsingariya/add/meshery-cillium

[Meshery] Handling unit tests failure
artukryp · Mar 28, 2022 · 14c4ee4 · 14c4ee4
2 parents 183fa44 + f3a81c4
commit 14c4ee4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/mesheryctl/internal/cli/root/system/testdata/context/addExpected.golden b/mesheryctl/internal/cli/root/system/testdata/context/addExpected.golden
@@ -30,6 +30,7 @@ contexts:
     - meshery-osm
     - meshery-traefik-mesh
     - meshery-nginx-sm
+    - meshery-cilium
     channel: stable
     version: latest
 current-context: local

diff --git a/mesheryctl/pkg/utils/helpers_test.go b/mesheryctl/pkg/utils/helpers_test.go
@@ -579,6 +579,9 @@ func TestSetOverrideValues(t *testing.T) {
 				"meshery-istio": map[string]interface{}{
 					"enabled": true,
 				},
+				"meshery-cilium": map[string]interface{}{
+					"enabled": false,
+				},
 				"meshery-linkerd": map[string]interface{}{
 					"enabled": false,
 				},
@@ -612,7 +615,7 @@ func TestSetOverrideValues(t *testing.T) {
 			name: "Context contains all available components and meshery image version",
 			ctx: &config.Context{
 				Components: []string{"meshery-istio", "meshery-linkerd", "meshery-consul", "meshery-kuma",
-					"meshery-osm", "meshery-nsm", "meshery-nginx-sm", "meshery-traefik-mesh", "meshery-cpx"},
+					"meshery-osm", "meshery-nsm", "meshery-nginx-sm", "meshery-traefik-mesh", "meshery-cpx", "meshery-cilium"},
 				Channel: testChannel,
 			},
 			mesheryImageVersion: "testImageVersion",
@@ -623,6 +626,9 @@ func TestSetOverrideValues(t *testing.T) {
 				"meshery-istio": map[string]interface{}{
 					"enabled": true,
 				},
+				"meshery-cilium": map[string]interface{}{
+					"enabled": true,
+				},
 				"meshery-linkerd": map[string]interface{}{
 					"enabled": true,
 				},
@@ -658,7 +664,7 @@ func TestSetOverrideValues(t *testing.T) {
 		got := SetOverrideValues(tt.ctx, tt.mesheryImageVersion)
 		eq := reflect.DeepEqual(got, tt.want)
 		if !eq {
-			t.Errorf("ReadToken got = %v want = %v", got, tt.want)
+			t.Errorf("SetOverrideValues %s got = %v want = %v", tt.name, got, tt.want)
 		}
 	}
 }