Merge pull request #1398 from artsy/DIA-784-web-build-new-sign-up-log…

…in-flow--2 fix(modaldialog): corrects type for title
artsy · Sep 3, 2024 · b098634 · b098634
2 parents c524b37 + 2221b97
commit b098634
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/palette/src/elements/ModalDialog/ModalDialog.story.tsx b/packages/palette/src/elements/ModalDialog/ModalDialog.story.tsx
@@ -122,6 +122,9 @@ export const Default = () => {
           title: "With custom z-index",
           zIndex: 1000,
         },
+        {
+          title: <Box bg="red">Custom title</Box>,
+        },
       ]}
     >
       {(props) => <Demo {...props} />}

diff --git a/packages/palette/src/elements/ModalDialog/ModalDialog.tsx b/packages/palette/src/elements/ModalDialog/ModalDialog.tsx
@@ -8,7 +8,7 @@ import { splitBoxProps } from "../Box"
 import { useDidMount } from "../../utils/useDidMount"
 import { useTheme } from "../../Theme"
 
-export type ModalDialogProps = ModalBaseProps &
+export type ModalDialogProps = Omit<ModalBaseProps, "title"> &
   ModalDialogContentProps & {
     leftPanel?: React.ReactNode
     rightPanel?: React.ReactNode