@orta: Fixes for Kiosk CC testing on Staging, Unresolved bids, Bidding errors #510
Conversation
|
ashfurrow
changed the title
| let signal = RACSignal.`if`(boolSignal, then: self.updateUser(), `else`: self.createNewUser()) | ||
|
|
||
| // After update/create signal finishes, add a CC to their account (if we've collceted one) |
|
structurally it looks good, but there's a lot of code in here with changes and no tests |
|
Cool, I'll add some tests. |
| @@ -3,8 +3,13 @@ import UIKit | |||
| class DeveloperOnlyView: UIView { | |||
|
|
|||
| override func awakeFromNib() { | |||
| let shouldShow = AppSetup.sharedState.showDebugButtons && AppSetup.sharedState.useStaging | |||
| let notTests = NSClassFromString("XCTest") == nil | |||
| self.hidden = !shouldShow && notTests | |||
There was a problem hiding this comment.
The logic here was messy, so I made it prettier.
|
OK, got the tests passing again, and added some minimal tests. The dev-only views were showing in some tests, which has been correct. Also, I changed the placeholder for the manual CC entry's year to be in the future. |
ashfurrow
changed the title
ashfurrow
force-pushed
the
error-messaging
branch
from
667039c to
10e079f
Compare
ashfurrow
changed the title
| expect(subject.bidderPosition?.id) == "5437dd107261692daa170000" | ||
| } | ||
|
|
||
| it("maps bid deatils into a proper request") { |
|
Blocker, this test seems wrong, either in the logic or the name |
|
No, that's correct. The bid has been submitted, we just don't know whether or not the user is the highest bidder. "Bid Submitted" is the most neutral language we could find. The previous screenshot was incorrect, as well, since it indicates you need to increase your bid (the test setup was wrong). |
|
I'll rename the test, remove "error" – good idea. |
|
Ace 👍 |
@orta: Fixes for Kiosk CC testing on Staging, Unresolved bids, Bidding errors
Fixes: