fix(fargate): set cloud endpoint from env in fargate containers #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InesNi
approved these changes
Jul 16, 2024
bernardobridge
deleted the
bernardobridge/art-1903-fix-tests-failing-due-to-api-key-issue-in-workers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes two issues:
/whoamicall in the container without taking into account the endpoint, so if the endpoint is not prod, the api key will not be correct, causing the error.ARTILLERY_CLOUD_API_KEYin the environment, but don't set--record, the key will still get passed to the worker, which causes the cloud logic to run unnecessarily (and error if not prod).Pre-merge checklist