Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ensure): check in beforeExit for both ensure plugin interfaces #1994

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Jul 17, 2023

What

Ensure plugin was not running checks at the end if config is passed like this:

  plugins:
    ensure:
      thresholds:
        - http.response_time.p99: 100
        - http.response_time.p95: 75

This happened since the beforeExit ext was not looking for the second input option.

Testing

Tested with:

config:
  target: http://asciiart.artillery.io:8080
  phases:
    - duration: 10
      arrivalRate: 1
  plugins:
    ensure:
      thresholds:
        - http.response_time.p99: 100
        - http.response_time.p95: 75
scenarios:
  - flow:
    - get:
        url: "/dino"

Also tried other variations (ensure outside of plugins), and no checks. All worked appropriately.

Copy link
Member

@manfromanotherland manfromanotherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bernardobridge 🙌

@hassy hassy merged commit d1136f3 into main Jul 17, 2023
3 checks passed
@hassy hassy deleted the bernardobridge/art-1149-passing-ensure-config-on-plugins-doesnt-work-for-ensure branch July 17, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants