fix(examples): use correct url so that all web vital metrics display #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
These examples weren't displaying web vital metrics by default.
The reason was the Artillery Playwright engine looks for
window.location.hrefas the url, and tries to match that with thetargetto decide on whether to show them or not. Since navigating to the website directs towww, that check was failing, and so no extended metrics were showing.Note: I also fixed the
cloudWaitlistSignupFlowwhich wasn't working properly. I used playwright's codegen as the previous one for an updated exmaple.