-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github action #1962
feat: add github action #1962
Conversation
Discovery: Flat GitHub inputsGitHub Actions' 👉 I'm merging the custom |
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected], [email protected] |
Accessing the binarySince we don't currently ship a Node.js API, we cannot list Artillery as a dependency of the action (nothing to bundle). Instead, there is an alternative. Download the CLI during the actionSimilar to setup actions, we can download the Artillery's CLI during the action run. Pros
Cons
|
We can circumvent the CLI version/action inputs dependency by fixing the version of the downloaded CLI in the action itself. That way we can version the action and keep the CLI version and the action's inputs in sync. I will check what's the versioning strategy for GitHub Actions and whether frequent releases are welcome. |
bf145bc
to
bc53c8a
Compare
Sticking with the Docker containerI think we will stick to the existing Docker container for now (as @hassy has rightfully pointed out). That'd also lift off all the workaround to make GitHub Actions execute CLIs as a part of the workflow. Once we publish a Node.js API, we may integrate it much easier with the action directly. |
0447074
to
e06dcf8
Compare
On using the report as the action's summaryThe HTML report we currently produce contains a few things that GitHub Markdown doesn't support (style definitions, custom script tags, interactivity). With that in mind, we can't reuse it 1-1 as the action's summary. We can iterate on the action and make it print a preview link to the dashboard once the user provides their credentials to access it. |
c485f9a
to
71b23ea
Compare
Automating the action buildWe don't have to build and commit the action upon every change. We only have to do that upon releasing it. Now, I need to learn more about how GitHub releases/versions the actions given that they're using repos as the registry for the actions (e.g. do they just pull whichever action state is on |
Closed in favor of artilleryio/action-cli#1. |
What
This pull requests adds an official GitHub Action for Artillery.
Why
Roadmap
prepare
the action before committing.References