fix(skytrace): send parsed json body correctly to expect plugin #1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Skytrace Smoke tests have been failing, due to a regression introduced by: 8a3e5c2
In reality, that logic is fine, but Skytrace was sending the body as a string when it should be an object (JSON).
This PR does the following:
test
instead ofmatch
instead, so a boolean is returned (rather than null) when there is no matchTesting
The following commands were used to test this:
(the failing test):