clean/rc argument parser #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specify default position value extract valid positions
restore bottomLeft default position for `small` list supported positions list in help
Argument Parser migration
Drop SwiftCLI arguments handling
Specify default values for color arguments
|
LGTM :) |
KyNorthstar
reviewed
Aug 2, 2020
| @@ -18,6 +18,10 @@ let package = Package( | |||
| from: "1.0.0" | |||
| ), | |||
| .package( | |||
| url: "https://github.com/apple/swift-argument-parser", | |||
There was a problem hiding this comment.
Danger: This can cause Xcode to not even want to start building: https://stackoverflow.com/q/63079909/3939277
adding .git to the end of the URL will solve that, and also might fix the thing down below where you had to use .product
There was a problem hiding this comment.
Oh, a nice catch :)
Converted into an issue #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #10 👏
For more information, see merged PR #18 from @elfenlaid
An attempt to get rid of
SwiftCLI.Taskis available at #20 by @tthbalazs, but due to performance issues can't yet be merged.