Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiple useCallbacks autofix): fix exception during autofix when multiple useCallbacks wants to add import #20

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix(multiple useCallbacks autofix): fix exception during autofix when multiple useCallbacks wants to add import #20

merged 2 commits into from
Oct 29, 2023

Conversation

pixellos
Copy link

No description provided.

@arthurgeron
Copy link
Owner

Thank you for your contribution. Can you please add a test with that case (import specifier already present)?

@arthurgeron
Copy link
Owner

Also please increase the patch version, instead of the minor, e.g 2.1.1

arthurgeron
arthurgeron requested changes Oct 29, 2023
View reviewed changes
src/common.ts Outdated Show resolved Hide resolved
@pixellos pixellos requested a review from arthurgeron October 29, 2023 07:43
@pixellos pixellos changed the title feat(modernize): update packages, fix import issue, when one import already is present fix(multiple useCallbacks autofix): fix exception during autofix when multiple useCallbacks wants to add import Oct 29, 2023
@arthurgeron
Copy link
Owner

Looks great. Thanks 👍

@arthurgeron arthurgeron merged commit a8296be into arthurgeron:main Oct 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurgeron arthurgeron arthurgeron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixellos @arthurgeron