fix: minimatch should ignore set to "false" not working

arthurgeron · Jan 20, 2024 · f8f9441 · f8f9441
1 parent b581a26
commit f8f9441
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/__tests__/require-usememo.test.ts b/__tests__/require-usememo.test.ts
@@ -581,6 +581,20 @@ describe('Rule - Require-usememo', () =>  {
         }`,
         errors: [{ messageId: "object-usememo-props" }],
       },
+      {
+        code: `import { useMemo } from 'react';
+        function useTesty() {
+          const x = {};
+          return useDataManager(x);
+        }`,
+        options: [{ checkHookReturnObject: true, ignoredHookCallsNames: {"useData*": false} }],
+        output: `import { useMemo } from 'react';
+        function useTesty() {
+          const x = useMemo(() => ({}), []);
+          return useDataManager(x);
+        }`,
+        errors: [{ messageId: "object-usememo-deps" }],
+      },
       {
         code: `
         const useTest = () => {

diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -131,17 +131,20 @@ export function shouldIgnoreNode(node: ESNode, ignoredNames: Record<string, bool
     }
 
     // Checking via patterns
-    const shouldIgnore = Object.keys(ignoredNames).find(key => {
+    let shouldIgnore;
+
+    Object.keys(ignoredNames).find(key => {
       const value = ignoredNames[key];
       const miniMatch = new Minimatch(key);
       if (miniMatch.hasMagic()) {
          const isMatch = (nameToCheck && miniMatch.match(nameToCheck));
           if (isMatch) {
-            return !!value;
+            shouldIgnore = !!value;
+            return true;
           }
       }
       return false;
     });
 
-    return shouldIgnore != undefined ? shouldIgnore : false;
+    return !!shouldIgnore;
 }